Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editMode Does not work after d3 v6 #77

Open
DishenWang2023 opened this issue Mar 24, 2021 · 1 comment
Open

editMode Does not work after d3 v6 #77

DishenWang2023 opened this issue Mar 24, 2021 · 1 comment

Comments

@DishenWang2023
Copy link

In v6, when editMode is set to true, the annotations are no longer draggable. Switching back to d3 v5 would solve this issue but this is most likely an issue for future uses

@Fil
Copy link
Collaborator

Fil commented Mar 24, 2021

d3-annotation requires modules d3-selection, d3-drag etc from d3v5, not v6.

The change that is probably impacting it is in https://github.com/susielu/d3-annotation/blob/master/src/Handles.js#L86; we'll need to add event as the first argument to event handlers. See the relevant migration guide: https://observablehq.com/@d3/d3v6-migration-guide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants