Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Rotation when Loading from URL #453

Open
woaiqiu947 opened this issue Sep 6, 2024 · 2 comments
Open

Image Rotation when Loading from URL #453

woaiqiu947 opened this issue Sep 6, 2024 · 2 comments

Comments

@woaiqiu947
Copy link

I encountered an issue where loading an image from a captured photo URL results in the image being rotated. However, when loading the same image using SDWebImage, it displays correctly without any rotation issues.

Steps to reproduce:


  1. Capture a photo using the device camera.
  2. Load the image URL using SKPhoto.photoWithImageURL(_:).
  3. The image may appear rotated.
    
    Interestingly, when using SDWebImage to load the same URL, the image is displayed correctly.
    
    It seems that SKPhotoBrowser may not be handling the image’s EXIF metadata, particularly the orientation information, causing the image to be displayed in the wrong orientation.
@woaiqiu947
Copy link
Author

pod 'SKPhotoBrowser', '~> 7.1.0'

@tommyming
Copy link
Collaborator

@woaiqiu947 Thanks for the issue report.
Would you please try out the main branch also? I don't have time to tag the latest version recently.
And 7.1.0 is already 2 years ago.

My assumption is:
The main branch also haven't solve this issue, since the library is using its own implementation on handling images.
SDWebImage/Kingfisher has handled EXIF data properly, from my pevious experience.

#452 also has a similar issue, base on image orientation. But the source is from device camera.

Will try to fix it when time allowed. Meanwhile, please feel free to create PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants