Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-inline-styles: Change the default value for allowTransitions to true #902

Open
marekdedic opened this issue Nov 3, 2024 · 1 comment · May be fixed by #911
Open

no-inline-styles: Change the default value for allowTransitions to true #902

marekdedic opened this issue Nov 3, 2024 · 1 comment · May be fixed by #911

Comments

@marekdedic
Copy link
Contributor

The no-inline-styles rule has an option controlling whether it reports the use of transitions as well. This was largely due to the fact that the built-in Svelte 4 transitions used inline styles and thus using them wasn't "safe" in a no-inline-styles webpage.

With Svelte 5, transitions apparently no longer use inline styles. Thus, I'd like to change the default behaviour of the rule to allowing transitions (I think we can keep the option to disallow them for those who want it.)

@ota-meshi
Copy link
Member

Wow, I didn't know that! The rule changes sound good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants