Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label order when generating bytecode #15

Open
Abhiroop opened this issue Jun 14, 2021 · 2 comments
Open

Label order when generating bytecode #15

Abhiroop opened this issue Jun 14, 2021 · 2 comments

Comments

@Abhiroop
Copy link
Collaborator

The ordering of labels seems to be slightly buggy. Occasionally they are not sorted by their label numbers. Commits attempting to fix the issue:

ff28b70
7d7fd97

The problem seems to be fixed in LLExamples.hs but now Examples.hs is broken.

@Abhiroop Abhiroop added bug Something isn't working middleware suspect and removed bug Something isn't working labels Jun 14, 2021
@Abhiroop
Copy link
Collaborator Author

These changes are most probably unnecessary. The assembler is designed in such a way such that, irrespective of the label numbers generated in the CAM IR, the assembler sequentially numbers them and all the label referring instructions (like GOTO, CALL etc) refer to the sequential number. Check buildST in the assembler.

Keeping this issue open in case we ever run into odd label numbering schemes in the bytecode.

@Abhiroop
Copy link
Collaborator Author

Reverted label sorting : 466f766

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant