Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

margin argument is not used (used value is just hardcoded) #344

Open
saurik opened this issue Mar 23, 2024 · 0 comments
Open

margin argument is not used (used value is just hardcoded) #344

saurik opened this issue Mar 23, 2024 · 0 comments

Comments

@saurik
Copy link

saurik commented Mar 23, 2024

The --margin argument is assigned to a field margin.

wmfocus/src/args.rs

Lines 128 to 130 in 241bac9

/// Add an additional margin around the text box (value is a factor of the box size)
#[arg(short, long, default_value = "0.2")]
pub margin: f32,

But margin_factor is just the hard-coded value of 0.2.

let margin_factor = 1.0 + 0.2;

The only three lines of code which are returned by a git grep -w margin are the three lines which set and document the field: there are no uses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant