-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sway support #53
Comments
I'm not opposed to it but I'm unlikely to implement it myself since I don't use Sway and Sway doesn't even run on my hardware unfortunately. However, I'm willing to accept a PR for this. |
Thank you for your reply. It's a pity but I understand. |
Well, would you like to take a stab at adding this? |
I'll do it if I have time 😉 |
I confirmed whether this app works on sway. |
Wow, really? :D |
Does it require XWayland to run or does it work natively on Wayland? |
I tested it on Wayland. It only sees the windows running under XWayland. It does not see Wayland-native apps. So, if you two most common apps are a Wayland-native terminal like Alacritty and a browser which supports Wayland directly, then it's pretty useless. |
This library can help implementing sway support https://crates.io/crates/swayipc |
I can't test Sway support as it doesn't run on my hardware. However, I'd be happy to accept contributions for this. |
@JayceFayne can you help on this, many thanks |
@svenstaro maybe we can keep this issue open.. |
Hey @ejez, I looked into this and from my understanding porting the IPC part is fairly easy. The problem that I see is drawing the window and therefore also grabbing the keyboard and mouse input since this is different in the X11/Wayland world. Since I do not have any experience writing that kind of code I could use some help porting these parts. I'll try to provide a pull for the IPC part as soon as I have some free time (maybe this weekend). |
This project may be an interesting reference since it implements Wayland client, server and protocols in Rust: |
@JayceFayne Sorry for the late reply... Thanks for looking at this. Hopefully with your help and help from others we will be able to stitch the pieces together and get it working. |
@svenstaro Any thoughts on merging this? |
Well, so I do want sway support but as it stands, it seems to sometimes freeze for users, and also it doesn't draw natively for Wayland apparently. I don't want to merge any half-baked things that I can't really test myself. |
Sway support is working now in #122 if anyone wants to test it. For now, the windows are drawn with X11, but as long as you are already using XWayland, you won't notice the difference. |
Do you have plans to support this app on the sway?
The text was updated successfully, but these errors were encountered: