From 9102aabdaca88ecd65597654e9da4fdd9a425200 Mon Sep 17 00:00:00 2001
From: John Kenny <johnkenny54@yahoo.com>
Date: Thu, 19 Sep 2024 06:49:05 -0700
Subject: [PATCH] Updated docs.

---
 docs/04-plugins/removeUnknownsAndDefaults.md  | 26 ++++++++++++++
 docs/04-plugins/removeUnknownsAndDefaults.mdx | 35 -------------------
 docs/plugins/removeUnknownsAndDefaults.md     | 26 ++++++++++++++
 docs/preset-default.md                        |  2 +-
 plugins/removeUnknownsAndDefaults.js          |  2 ++
 5 files changed, 55 insertions(+), 36 deletions(-)
 create mode 100644 docs/04-plugins/removeUnknownsAndDefaults.md
 delete mode 100644 docs/04-plugins/removeUnknownsAndDefaults.mdx
 create mode 100644 docs/plugins/removeUnknownsAndDefaults.md

diff --git a/docs/04-plugins/removeUnknownsAndDefaults.md b/docs/04-plugins/removeUnknownsAndDefaults.md
new file mode 100644
index 0000000..9a58f1c
--- /dev/null
+++ b/docs/04-plugins/removeUnknownsAndDefaults.md
@@ -0,0 +1,26 @@
+# removeUnknownsAndDefaults
+
+Removes unknown elements and attributes, as well as attributes that are set to their default value.
+It also removes the the `standalone` declaration from the DTD if [`standalone`](https://www.w3.org/TR/REC-xml/#sec-rmd) is set to `no`.
+
+The plugin has no effect if:
+
+- The document has scripts.
+- The document has `<style>` elements with CSS which **svgo-ll** is not able to process.
+
+The following elements are not processed:
+
+- Any element with a namespace prefix.
+- Any `<foreignObject>` elements and their children.
+- Any attributes whose name starts with `aria-` or `data-i`.
+- `xmlns` attributes are never removed.
+- Attribues with a namespace prefix are never removed unless the prefix is `xml` or `xlink`.
+
+Elements are removed if:
+
+- They are not allowed as children of their parents.
+
+Attributes set to a default value are removed if:
+
+- They are not overriding a value set by an ancestor, and
+- they are not in an element which is referenced by a `<use>` element (or a child of any such element)
diff --git a/docs/04-plugins/removeUnknownsAndDefaults.mdx b/docs/04-plugins/removeUnknownsAndDefaults.mdx
deleted file mode 100644
index 8a96d80..0000000
--- a/docs/04-plugins/removeUnknownsAndDefaults.mdx
+++ /dev/null
@@ -1,35 +0,0 @@
----
-title: removeUnknownsAndDefaults
-svgo:
-  pluginId: removeUnknownsAndDefaults
-  defaultPlugin: true
-  parameters:
-    unknownContent:
-      description: If to remove elements that are not known or can't be the child of the parent element according.
-      default: true
-    unknownAttrs:
-      description: If to remove attributes that are not assignable to the respective element.
-      default: true
-    defaultAttrs:
-      description: If to remove attributes that are assigned their default value anyway.
-      default: true
-    defaultMarkupDeclarations:
-      description: If to remove XML declarations that are assigned their default value. XML declarations are the properties in the `<?xml … ?>` block at the top of the document.
-      default: true
-    uselessOverrides:
-      description: If to remove attributes that are being if the same value is being inherited by it's parent element anyway.
-      default: true
-    keepDataAttrs:
-      description: If to keep [`data-*`](https://developer.mozilla.org/docs/Web/SVG/Attribute/data-*) attributes.
-      default: true
-    keepAriaAttrs:
-      description: If to keep [ARIA (Accessible Rich Internet Applications)](https://developer.mozilla.org/docs/Web/Accessibility/ARIA) attributes, used for accessibility. This excludes `role`, which is managed with the `keepRoleAttr` parameter.
-      default: true
-    keepRoleAttr:
-      description: If to keep the ARIA [`role`](https://developer.mozilla.org/docs/Web/Accessibility/ARIA/Roles) attribute.
-      default: false
----
-
-Removes unknown elements and attributes, as well as attributes that are set to their default value.
-
-This can also remove defaults from the XML declaration if present in the document, namely [`standalone`](https://www.w3.org/TR/REC-xml/#sec-rmd) if it's set to `no`.
diff --git a/docs/plugins/removeUnknownsAndDefaults.md b/docs/plugins/removeUnknownsAndDefaults.md
new file mode 100644
index 0000000..9a58f1c
--- /dev/null
+++ b/docs/plugins/removeUnknownsAndDefaults.md
@@ -0,0 +1,26 @@
+# removeUnknownsAndDefaults
+
+Removes unknown elements and attributes, as well as attributes that are set to their default value.
+It also removes the the `standalone` declaration from the DTD if [`standalone`](https://www.w3.org/TR/REC-xml/#sec-rmd) is set to `no`.
+
+The plugin has no effect if:
+
+- The document has scripts.
+- The document has `<style>` elements with CSS which **svgo-ll** is not able to process.
+
+The following elements are not processed:
+
+- Any element with a namespace prefix.
+- Any `<foreignObject>` elements and their children.
+- Any attributes whose name starts with `aria-` or `data-i`.
+- `xmlns` attributes are never removed.
+- Attribues with a namespace prefix are never removed unless the prefix is `xml` or `xlink`.
+
+Elements are removed if:
+
+- They are not allowed as children of their parents.
+
+Attributes set to a default value are removed if:
+
+- They are not overriding a value set by an ancestor, and
+- they are not in an element which is referenced by a `<use>` element (or a child of any such element)
diff --git a/docs/preset-default.md b/docs/preset-default.md
index 14a1cbb..ab28213 100644
--- a/docs/preset-default.md
+++ b/docs/preset-default.md
@@ -18,7 +18,7 @@ The following plugins are included in `preset-default`, in the order that they'r
 - cleanupIds
 - removeUselessDefs
 - convertColors
-- removeUnknownsAndDefaults
+- [removeUnknownsAndDefaults](./plugins/removeUnknownsAndDefaults.md)
 - removeNonInheritableGroupAttrs
 - removeUselessStrokeAndFill
 - removeHiddenElems
diff --git a/plugins/removeUnknownsAndDefaults.js b/plugins/removeUnknownsAndDefaults.js
index 64bc350..1c2b214 100644
--- a/plugins/removeUnknownsAndDefaults.js
+++ b/plugins/removeUnknownsAndDefaults.js
@@ -198,6 +198,7 @@ export const fn = (root, params, info) => {
             parentNode.name,
           );
           if (allowedChildren == null || allowedChildren.size === 0) {
+            // TODO: DO WE NEED THIS CHECK? SHOULDN'T IT HAVE BEEN HANDLED BY THE PARENT IN THE ELSE BLOCK BELOW?
             // remove unknown elements
             if (allowedChildrenPerElement.get(node.name) == null) {
               detachNodeFromParent(node, parentNode);
@@ -263,6 +264,7 @@ export const fn = (root, params, info) => {
               saveForUsageCheck(node, name);
             }
           }
+          // TODO: DO WE NEED THE ID CHECK? SEEMS LIKE THIS IS HANDLED BY CHECKING FOR USE
           if (uselessOverrides && node.attributes.id == null) {
             const computedValue = computedParentStyle
               ? computedParentStyle.get(name)