Draft: FindSources w/o always fetching all tags #102
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16Martin
force-pushed
the
martin/guess-github-tags
branch
from
cfac998
to
fa9beb7
Compare
16Martin
force-pushed
the
martin/guess-github-tags
branch
from
fa9beb7
to
72e1fb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #99 and introduces code intended to replace the current combination of
get_github_info()followed byget_matching_tag()which exists only incapycli.bom.findsources.This approach first tries to match a tag using the original
get_matching_tag(). If all the guessing does not yield any results, the algo implicitly falls back to analyzing each tag withget_matching_tag().