Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[es/typescript] swc should drop this #8156

Closed
magic-akari opened this issue Oct 20, 2023 · 2 comments · Fixed by #8158
Closed

[es/typescript] swc should drop this #8156

magic-akari opened this issue Oct 20, 2023 · 2 comments · Fixed by #8158
Assignees
Milestone

Comments

@magic-akari
Copy link
Member Author

🔍 Investigation: the AST of SetterProp is wrong.

#[ast_node("SetterProperty")]
#[derive(Eq, Hash, EqIgnoreSpan)]
#[cfg_attr(feature = "arbitrary", derive(arbitrary::Arbitrary))]
pub struct SetterProp {
pub span: Span,
pub key: PropName,
pub param: Box<Pat>,
#[cfg_attr(feature = "serde-impl", serde(default))]
pub body: Option<BlockStmt>,
}

@kdy1 kdy1 added this to the Planned milestone Oct 20, 2023
@kdy1 kdy1 self-assigned this Oct 20, 2023
kdy1 added a commit that referenced this issue Oct 20, 2023
**Description:**

This is not a proper fix, but let's wait for the conf.

**Related issue:**

 - Closes #8156
@kdy1 kdy1 modified the milestones: Planned, v1.3.94 Oct 21, 2023
@swc-bot
Copy link
Collaborator

swc-bot commented Nov 20, 2023

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants