Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated KubernetesServiceDiscovery lookup #1

Open
segabor opened this issue Nov 11, 2024 · 2 comments
Open

Outdated KubernetesServiceDiscovery lookup #1

segabor opened this issue Nov 11, 2024 · 2 comments

Comments

@segabor
Copy link

segabor commented Nov 11, 2024

First off, you did an amazing work! Thanks for that.

Unfortunately the project doesn't build, supposedly due to a breaking change in a dependency.

lookup method in SwiftKubeServiceDiscovery class has two problems,

  1. whenComplete completion callback no longer exists. I suppose it has been superseded by async / await structure.
  2. So the method itself should be transformed to an async function.
@iabudiab
Copy link
Member

@segabor thank you for raising the issues. I must admit, that I've neglected this module and didn't update it promptly. I have, however, started a new branch with an almost complete overhaul using structured concurrency a while back but got distracted and didn't finish it.

I'll give it another go as soon as I get a couple of days with some free time 😉

@segabor
Copy link
Author

segabor commented Nov 13, 2024

Sounds great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants