You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now, all endpoints return OkResponse (or ErrResponse), which hold an arbitrary JSON string. Instead, it would be nice to have explicit types for some (all?) the endpoints, such that the objects can be automatically serialized through serde? For example, check_update_function could actually return Cardinality(f64) or ErrorMessage(String) instead of the generic response types.
This does not help that much on the JS side, since we have no type-checking there, but it helps future maintainers by clearly specifying what is/isn't a valid response from a particular endpoint.
The text was updated successfully, but these errors were encountered:
Right now, all endpoints return
OkResponse
(orErrResponse
), which hold an arbitrary JSON string. Instead, it would be nice to have explicit types for some (all?) the endpoints, such that the objects can be automatically serialized throughserde
? For example,check_update_function
could actually returnCardinality(f64)
orErrorMessage(String)
instead of the generic response types.This does not help that much on the JS side, since we have no type-checking there, but it helps future maintainers by clearly specifying what is/isn't a valid response from a particular endpoint.
The text was updated successfully, but these errors were encountered: