Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider conversions for expression literals/constants. #13

Open
daemontus opened this issue Mar 31, 2024 · 0 comments
Open

Consider conversions for expression literals/constants. #13

daemontus opened this issue Mar 31, 2024 · 0 comments

Comments

@daemontus
Copy link
Member

We could probably add From implementation for the Expression type that would convert bool, String, &str, etc. into a Constant or Literal expression. Using generics, we could then make methods like binary_or work with any type that converts into an Expression. This would simplify building expressions in code, but could lead to confusion if we overdo it. I'm not quite sure what route to take here, but I'm leaving this here as a suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant