Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equivalence for errors #9

Open
daemontus opened this issue Mar 27, 2024 · 0 comments
Open

Equivalence for errors #9

daemontus opened this issue Mar 27, 2024 · 0 comments

Comments

@daemontus
Copy link
Member

Right now, all errors seem to implement PartialEq, but mostly it is derived, only for the bindings errors it needs to be implemented explicitly based on the enum discriminant. I'm not quite sure how to interpret this. What are the equality criteria for the derived case? Is it the data in the error or just discriminant? If it's the data, shouldn't we try to have something like that for the Python errors as well? If it's just the discriminant, this should probably be documented somewhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant