Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated code from before TSF v5.1 #691

Open
sybrew opened this issue Nov 4, 2024 · 0 comments
Open

Remove deprecated code from before TSF v5.1 #691

sybrew opened this issue Nov 4, 2024 · 0 comments
Assignees
Labels
[Type] Code debt Structural changes in the code are required to resolve this.
Milestone

Comments

@sybrew
Copy link
Owner

sybrew commented Nov 4, 2024

In TSF v5.0, released on November 22, 2023, we were left with over 420 deprecations:

  1. 388 methods
  2. 4 classes
  3. 11 properties
  4. 35 filters
  5. 1 action

Purging them will ease maintenance and reduce the plugin's size by about 10%.

If we remove the deprecated classes, sites could experience crashes — we currently handle these via class extensions.

Automated deprecation handlers account for methods and properties; still, removing those could result in unexpected values being returned to the caller. Here are all deprecated methods.

Filters and action removal should only affect behavior; probably, no one will notice that.

We'll see TSF v5.2 in Summer 2025 at the earliest. A 1.5-year window would be plenty for migrations; I also offered to update all deprecated code any user would have, and that offer still stands.

@sybrew sybrew added the [Type] Code debt Structural changes in the code are required to resolve this. label Nov 4, 2024
@sybrew sybrew added this to the 5.2.0 milestone Nov 4, 2024
@sybrew sybrew self-assigned this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Code debt Structural changes in the code are required to resolve this.
Projects
None yet
Development

No branches or pull requests

1 participant