Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] Implement png specific splits. #6

Open
fboucquez opened this issue Oct 25, 2021 · 0 comments
Open

[Storage] Implement png specific splits. #6

fboucquez opened this issue Oct 25, 2021 · 0 comments

Comments

@fboucquez
Copy link
Contributor

fboucquez commented Oct 25, 2021

The split could be done 1) when storing the chunks (so each chunk is a specific png section) or 2) when loading the chunks (only a subsection of the 1024 chunk is processed and returned from the message)

  1. On the way in: https://github.com/symbol/garush/blob/main/packages/storage/src/FileParser.ts#L16 Find a nice lib to split. Chunks could be smaller, so more aggregates are required. The network fees would be slightly higher.

  2. On the way out: It depends on how "file" headers are loaded [Storage] Implement File "Header" loading #5

Note that atm rest and the SDK don't let you load just 1 transfer inner transaction of an aggregate transaction. The whole initial 100 transfers of the first data aggregate would be loaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant