Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup questions #97

Closed
dbu opened this issue Jan 27, 2014 · 3 comments · Fixed by #108
Closed

cleanup questions #97

dbu opened this issue Jan 27, 2014 · 3 comments · Fixed by #108

Comments

@dbu
Copy link
Member

dbu commented Jan 27, 2014

i started on the refactoring and stumbled over a couple of questions / suggestions:

  • can we get rid of simplecms page creationDate? we have the publishStartDate that could serve the same purpose in most use cases.
  • what about mapping route referrers to simple cms pages and merge $this with those referrers? then you could do a "main language" and additional translated urls pointing to the main language.
  • any opposition over adding an additionalInfoBlock child on the Page, as in StaticContent?
@dbu
Copy link
Member Author

dbu commented Apr 15, 2014

@lsmith77 can you give some feedback here?

@lsmith77
Copy link
Member

  • "can we get rid of simplecms page creationDate? we have the publishStartDate that could serve the same purpose in most use cases." +1
  • "what about mapping route referrers to simple cms pages and merge $this with those referrers? then you could do a "main language" and additional translated urls pointing to the main language." not quite sure I understand
  • "any opposition over adding an additionalInfoBlock child on the Page, as in StaticContent?" no +1

I think 1) + 3) sound fine to me and should be easy enough. 2) sounds complicated and therefore can likely wait for 1.2

@dbu
Copy link
Member Author

dbu commented Apr 15, 2014

created a PR for 1 and 3 and a new issue #109 for 2

@dbu dbu closed this as completed Apr 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants