-
-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dropzone] - Problems after #2154 ? #2311
Comments
I'm very sorry if this is related to recent changes. If you could provide me some minimal reproducer (even textual / step by step one), i will investigate to provide a quick fix |
I could not replicate it yet. But maybe this video helps. Is is not the same error. |
At the beginning of your video, the preview block is enabled but with no previous upload... maybe you did send it, and did not restore initial state of the component ? |
Yes. You can see a bit more in this video. The empty preview block needs to be manual cleared by clicking on the |
Sorry if this is related my last PR, i can't reproduce it, waiting for a minimal repro |
Don't worry @Chris53897! Changes sometimes impact this gray zone of non-documented behaviour, zone that existing project may be counting on. We will react and fix what we can as soon we can reproduce ;) And thank you again for your PR ;) |
I have downgraded to 2.20 and check if the error still occurs. Just to be sure, that 2.21 is the reason for the problem. |
I really tried hard and could not reproduce your problem. I'm seeing the expected behaviour on this dropzone demo (running the 2.21 version) on Symfony UX website. Fact is: the PR from @rrr63 did not change a thing on how the component should render on page load. It only deals with dragenter/dragleave. On your video, the "close preview button" should not be visible in the first place. Maybe you do have some custom CSS with special rules or some JS code that interact with the component on render ? |
I also tried to reproduce this bug, unsuccessful. As @smnandre said, I think it could happen by some 'custom' JS/CSS files |
We noticed problems with Dropzone after the lastest update from 2.20.0 => 2.21.0
Most of the times Adding (not replaceing) works correct.
But sometimes (tested on Safari and Chrome) on/after the drop, the following errors occurs.
In our case it happens with .pdf-Files
After a new load of the page. The area inside the dotted line is empty. But the "x" button ont the right side is visible.
Error repeats now.
I assume related to.
@rrr63 Maybe you can have a look?
#2154
I will provide more info if i find a way to reproduce it.
The text was updated successfully, but these errors were encountered: