Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in camera filtering for bundle_adjustment_in_the_large example #408

Open
MGBzH opened this issue Nov 22, 2024 · 0 comments
Open

Error in camera filtering for bundle_adjustment_in_the_large example #408

MGBzH opened this issue Nov 22, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@MGBzH
Copy link

MGBzH commented Nov 22, 2024

The example bundle_adjustment_in_the_large.cc first loads observations, camera poses with intrinsics and points from a text file. Then the function FilterCameraOutliers is called to remove cameras that are wrongly initialized being too far from the centroid of all the cameras.
However this function seems to remove too many factors. On the problem 21-11315, 36455 factors and 21 cameras are fed to this function which returns only 21 factors that are then optimized.
I don't think this problem contains any wrongly initialized camera, so I think all the factors should be kept?
I assume that the error is coming from l. 62 where a single factor per camera is kept in the filtered_factors instead of keeping all the factors connected to the good camera.

@MGBzH MGBzH added the bug Something isn't working label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant