Skip to content
This repository has been archived by the owner on Nov 27, 2017. It is now read-only.

Remove GITHUB_CLIENT_ID and GITHUB_CLIENT_SECRET #117

Open
tplevko opened this issue Oct 9, 2017 · 2 comments
Open

Remove GITHUB_CLIENT_ID and GITHUB_CLIENT_SECRET #117

tplevko opened this issue Oct 9, 2017 · 2 comments

Comments

@tplevko
Copy link
Contributor

tplevko commented Oct 9, 2017

Are these two properties necessary now that github is no longer used?
@zregvart
Copy link
Member

Yup not used, we should remove them.

@rhuss
Copy link
Contributor

rhuss commented Oct 11, 2017

Let's wait a bit until we completely remove KeyCloak (as its part of the keycloak config), so we could do it in one step.

@syndesis-bot syndesis-bot mentioned this issue Nov 15, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rhuss @zregvart @tplevko