-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move cursor to username text box when logging in #196
Comments
@YashdalfTheGray @Mctalian My solution to this works for the login dialogue! Yay! Unfortunately, it doesn't work for the comments/backs tabs. I'm guessing because those cards are hidden behind nf-ifs instead of being loaded as new pages? I got my solution from this SO answer. Maybe we could run a bit of code to set focus on those input fields when those ng-ifs evaluate true? Pull down my master and let me know what you think plz! |
Tag anyone else you think would be interested, i always try to limit tags so as not to spam... but we all starred the repo for notifications anyway! |
I think I might have a potential solution to this... I'm pulling down your changes now to try to diagnose what's going on |
So it does work, kind of... if you login and then navigate to the idea that you're the author of, or on the team, the update text field will get focused. So I don't think it's an ng-if evaluation problem, the problem is it gets evaluated once and only once. We need a way to trigger it on demand if we need to. I have something working over here, it adds an isolated scope to the autoFocus directive allowing us to pass in an expression. We can then leverage In the link function of the directive, we watch for any changes of the value that's being passed in using It works for Updates tab, Comments tab, editing idea, adding new idea, login screen. Let me know if you want to work on this at some point or need some guidance. |
I'll need help. I got close on my own but didn't see the right behavior. Bob will help me this week. |
When clicking the log in button, the cursor should jump to the username text field so that the user can immediately start typing their username.
The text was updated successfully, but these errors were encountered: