You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed that there is currently some inconsistency between which default values are always set to defaults and/or serialized and which aren't. For example, node translation/rotation/scale is just parsed/serialized as-is, ignoring defaults. What is your preferred approach?
This may be a difficult question.
For a short-term perspective, I'd prefer ignore default values when serializing(this will save .gltf file size) and set default values when there is no corresponding entries in glTF at parsing.
For a mid-term perspective, it would be better to introduce an option whether ignore/not-set or export/set default values in serializer/parser, since default value may be changed in the future glTF spec(by minor updating) and some people may want force output full description of glTF data in the serializer.
For a long-term perspective, we are better to transit to automatically generate parser/serializer based on JSON schema to avoid human errors > #10
I see. I don't think I'll get around to change this any time soon, but let's discuss it anyway (for others).
The mid-term solution is logical. It is not a lot of extra work to begin with this; simply a boolean or define to set? I remember you weren't fond of adding more defines in the past, do you have a preferred approach to that?
The long-term solution is nice, but that seems quite far away indeed. Let's get RapidJSON to work first. 👍
The text was updated successfully, but these errors were encountered:
The long-term solution is nice, but that seems quite far away indeed. Let's get RapidJSON to work first.
rapidjson branch and master now has some divergence. It requires some effort to transit to use RapidJson only and deprecate json.hpp.
Before the RapidJson transition, I'm considering to let tinygltf co-exist rapidjson and json.hpp in master branch and switch JSON backend by using a define(e.g. TINYGLTF_USE_JSON_BACKEND_RAPIDJSON).
Continued discussion from #193 .
I see. I don't think I'll get around to change this any time soon, but let's discuss it anyway (for others).
The mid-term solution is logical. It is not a lot of extra work to begin with this; simply a boolean or define to set? I remember you weren't fond of adding more defines in the past, do you have a preferred approach to that?
The long-term solution is nice, but that seems quite far away indeed. Let's get RapidJSON to work first. 👍
The text was updated successfully, but these errors were encountered: