You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
after working with the code for a bit I have a question regarding the internals. While the serialiser uses a const and a non-const reference for in- and output, the parser uses a pointer. This seems a bit odd. What was the intended purpose here?
I'm asking because only the low-level functions perform a nullptr check and the high-level functions don't. I'm thinking about replacing the pointer with a writable reference, because that's much safer, obviously. What do you think?
Best...
The text was updated successfully, but these errors were encountered:
Hi @syoyo,
after working with the code for a bit I have a question regarding the internals. While the serialiser uses a const and a non-const reference for in- and output, the parser uses a pointer. This seems a bit odd. What was the intended purpose here?
I'm asking because only the low-level functions perform a nullptr check and the high-level functions don't. I'm thinking about replacing the pointer with a writable reference, because that's much safer, obviously. What do you think?
Best...
The text was updated successfully, but these errors were encountered: