Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about the (internal) parser signature #428

Closed
agnat opened this issue Jun 9, 2023 · 1 comment
Closed

Question about the (internal) parser signature #428

agnat opened this issue Jun 9, 2023 · 1 comment
Labels

Comments

@agnat
Copy link
Contributor

agnat commented Jun 9, 2023

Hi @syoyo,

after working with the code for a bit I have a question regarding the internals. While the serialiser uses a const and a non-const reference for in- and output, the parser uses a pointer. This seems a bit odd. What was the intended purpose here?

I'm asking because only the low-level functions perform a nullptr check and the high-level functions don't. I'm thinking about replacing the pointer with a writable reference, because that's much safer, obviously. What do you think?

Best...

@syoyo syoyo added the invalid label Jun 10, 2023
@syoyo
Copy link
Owner

syoyo commented Jun 10, 2023

You should describe your question in detail, following #291

@syoyo syoyo closed this as completed Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants