-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Typescript #50
Conversation
@Jack-Barry Could you merge with updated upstream master please? |
One thing to note here is that the code coverage percentage currently reported (95%) will drop significantly. Given the brittle nature of some of the tests this doesn't surprise me, I am inclined to believe the new value reported is more accurate. If there's something I missed in updating the coverage reporting in the shift over to TS just let me know, thanks! |
@Jack-Barry Good stuff, many thanks! |
Thanks for biting this one off. |
@Jack-Barry I fully agree! :) |
What's the problem this PR addresses?
Removes Flow and switches the repo over to TypeScript, as per discussion in #17
How did you fix it?
flow-to-ts
to convert allsrc
filesflow-to-ts
to convert applicabletest
files// @ts-ignore
where it wasn't worth the battle for nowSome of these commits overlap with #49 PR but I'm keeping this one separate for tracking purposes since it's a different issue being addressed more massive overhaul of the tooling. The other PR is ready to go and has passed all tests whereas this one needs to be vetted via CI tooling and probably requires further review.