Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate more metrics on connection pool #703

Closed
renecannao opened this issue Sep 25, 2016 · 6 comments
Closed

Generate more metrics on connection pool #703

renecannao opened this issue Sep 25, 2016 · 6 comments

Comments

@renecannao
Copy link
Contributor

When an error like Max connect timeout reached while reaching hostgroup X happens, the client is notified but there is no visibility in Admin module.
This information should be available in table stats_mysql_global

@renecannao renecannao self-assigned this Sep 25, 2016
renecannao added a commit that referenced this issue Sep 25, 2016
Metrics introduced:
* ConnPool_get_conn_failure : connection pool cannot provide any connection
* ConnPool_get_conn_immediate : connection is provided from per-thread cache
* ConnPool_get_conn_success : the session is able to get a connection, either from per-thread cache or connection pool
@renecannao renecannao changed the title Generate a new metric for unreachable hostgroups Generate more metrics on connection pool Sep 25, 2016
@renecannao
Copy link
Contributor Author

Metrics introduced:

  • ConnPool_get_conn_failure : connection pool cannot provide any connection
  • ConnPool_get_conn_immediate : connection is provided from per-thread cache
  • ConnPool_get_conn_success : the session is able to get a connection, either from per-thread cache or connection pool

@renecannao
Copy link
Contributor Author

TODO: document it

@thangola
Copy link

thangola commented Jun 5, 2018

@renecannao Are CoonnPool metrics gauge or counter?

@pondix
Copy link
Contributor

pondix commented Jun 5, 2018

It is a combination of both:

       ConnUsed: gauge
       ConnFree: gauge
         ConnOK: counter
        ConnERR: counter
        Queries: counter
Bytes_data_sent: counter
Bytes_data_recv: counter
     Latency_us: gauge

@thangola
Copy link

thangola commented Jun 5, 2018

@pondix how about ConnPool_get_conn_* ?

@pondix
Copy link
Contributor

pondix commented Jun 5, 2018

Those are global counters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants