Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: new gloval_variable digest_use_lowercase #725

Closed
btkador opened this issue Oct 9, 2016 · 2 comments
Closed

feature request: new gloval_variable digest_use_lowercase #725

btkador opened this issue Oct 9, 2016 · 2 comments
Assignees
Milestone

Comments

@btkador
Copy link

btkador commented Oct 9, 2016

Normally hashes are case sensitive, but I'm not sure if it is supposed to be related to digest_text, since mysql doesn't care if statements are lower or upper case.

mysql> select digest,digest_text from stats_mysql_query_digest where digest_text 
like "select id from sample_table limit ?";

+--------------------+--------------------------------------+
| digest             | digest_text                          |
+--------------------+--------------------------------------+
| 0xE1612CA769ADE07E | SELECT id from sample_table limit ?  |
| 0x575A2061B1BCC5F0 | select id from sample_table limit ?  |
+--------------------+--------------------------------------+

How about a global variable like digest_use_lowercase which is default 0, but if set to 1 always convert digest_text to lowercase before creating the digest, to don't break compatibility with existing installations using the hash?

Otherwise rules on digest won't match if a user uses uppercase, while the rule was based on lowercase - so it's somehow related on #717 :-)

@renecannao
Copy link
Contributor

Seems a valid feature request!
Thanks

@renecannao renecannao self-assigned this Oct 9, 2016
@renecannao renecannao added this to the v1.3 milestone Oct 9, 2016
@renecannao
Copy link
Contributor

Commit d1b40f7 introduces new variable mysql-digests_lowercase, false by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants