Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can --admin-socket override the saved config? #894

Closed
Roguelazer opened this issue Jan 27, 2017 · 2 comments
Closed

can --admin-socket override the saved config? #894

Roguelazer opened this issue Jan 27, 2017 · 2 comments
Assignees
Milestone

Comments

@Roguelazer
Copy link

Roguelazer commented Jan 27, 2017

I'm trying to build out a graceful restart strategy for proxysql (for new releases, since they happen a lot and our current strategy of using keepalived to fail over the whole host for proxysql restart suscks). My current plan is to start a new instance (on a different admin socket) with the same config as the main instance, shut down the existing instance with the PROXYSQL SHUTDOWN command (which looks like it is a graceful shutdown), then reverse the process to flip back to the "normal" instance.

I'm currently stymied by the fact that the command line argument --admin-socket seems to be ignored if the admin-mysql_ifaces global variable is set, so there's no way for me to run two instances with different admin sockets without having totally different on-disk configuration files.

Would it be reasonable to make --admin-socket either override admin-mysql_ifaces or add to it?

@renecannao renecannao self-assigned this Feb 16, 2017
@renecannao
Copy link
Contributor

This is an important enhancement.
The reason why admin-mysql_ifaces overrides the command line argument --admin-socket is that it is possible to change admin-mysql_ifaces at runtime.
Therefore a solution could be that admin-mysql_ifaces does not overrides the command line argument --admin-socket at startup only

@renecannao renecannao added this to the v1.3.4 milestone Feb 16, 2017
@renecannao
Copy link
Contributor

Enhancement applied to both 1.3.4-dev and 1.4.0

minichate pushed a commit to minichate/proxysql that referenced this issue Mar 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants