Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is an extra "$fn=24" being passed in to cylinder() ? #9

Open
JeffB42 opened this issue Apr 9, 2024 · 0 comments
Open

Is an extra "$fn=24" being passed in to cylinder() ? #9

JeffB42 opened this issue Apr 9, 2024 · 0 comments

Comments

@JeffB42
Copy link

JeffB42 commented Apr 9, 2024

When I import Threaded Library/Thread_Library.scad, I'm getting a warning about the arguments being passed in to cylinder() at line 222.

The code that's in master is:

	cylinder(
		h=2*countersunk*pitch, 
		r1=pitchRadius+clearance*pitch+0.25*pitch,
		r2=pitchRadius+clearance*pitch+0.25*pitch+2*countersunk*pitch,$fn=24,
		$fn=24
			);

Is there an extra $fn=24 here?

Should it be:

	cylinder(
		h=2*countersunk*pitch, 
		r1=pitchRadius+clearance*pitch+0.25*pitch,
		r2=pitchRadius+clearance*pitch+0.25*pitch+2*countersunk*pitch,
		$fn=24
			);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant