penf library files missing inside "/src/third_party/BeFoR64"

[AliE89]

Hello Stefano,
First of all thanks for this fine contribution! This is a very usefull piece of work for a FORTRAN programmer.

Since I see that you are still active on this project, then I have a couple of "fixes" to compile the master branch:

• Make is looking for the PENF library in /src/third_party/BeFoR64/, thus they have to be moved manually to compile.

• There is a typo in the extension of "foxy_xml_tag.F90", since Make is looking for "foxy_xml_tag.f90" and this cause make to crash.

Thank you very much again for this lib!!!

[AliE89]

Hi @szaghi, also it looks like the API page is not working. Any change to get the manual? :)

[szaghi]

@AliE89

Thank you very much for reporting the bug. The makefile is not well maintained because I use FoBiS thus it has many bugs. I will fix them soon.

Concerning the API page I'll fix it as well.

Cheers

[AliE89]

Thank you very much for this! Also I am wondering if the current version still supports vtk legacy. Does it? I see that there is a folder called reference, but iti s not compiled by the makr file.

[szaghi]

@AliE89

sorry for the ambiguity, but the reference/legacy directory contains just old legacy sources. If you mean if VTKFortran support "VTK legacy format", it should (but not tested recently, maybe I have dropped the support at some points in the past).

[AliE89]

That's cool. Cause I have found also your version 1.2 that looks to have this feature. I have complied it but not tested yet. Has the library massively changed? Honestly I will be happy just to save in binary :) I can also consider ti switch to xml if you advise so! :)

[szaghi]

Completely refactored from the old version. It works and many still use the old version, but I will not fix bug on it or implement new features into it. XML is a much more powerful format, it is a much better format than the old legacy one.

Cheers

[AliE89]

Ok so I will go for it! Let me known whrn the api is working :) thank you very much for this nice piece of work!

[szaghi]

I have reopened this: I would like to fix the makefile and API page before closing it.

[szaghi]

@AliE89

I have just uploaded a version (into master branch) with amended makefile and I have updated the online API documentation pages.

Let me know if this update solves this issue.

Cheers

[AliE89]

Cool, thank you very much! I am going to test the library in my code and see if it helps! Also i will get you back on the compilation problem I have seen so far!

[AliE89]

Hi @szaghi ,

now the library compiles as smooth as silk! But I am getting issues while compiling my code on penf (e.g.)

undefined reference to `__penf_stringify_MOD_str_r4p'

this comes out when I call ierr = vtk_field_file%initialize(format='binary', filename='myField.vtu', mesh_topology='UnstructuredGrid').

Any Hint?

[AliE89]

I have found out that you need to link the program to penf when compiling, otherwise the compiler can found the modules related to penf but not libpenf.a which is not compiled by the makefile of vtkfortran. This can be a potential issue as well maybe , I let you decide about this :)

[AliE89]

So in the end I make the library works! Thank you very much for this, you saved me a lot of time. The last issue that I see is that the code takes a lot of time to write in ascii, but the binary and raw looks ok! I think you can close the issue!

[rob-777]

@szaghi Thank you for your work. However, I'm encountering problems with penf.f90:

$ FoBiS.py build -mode static-gnu
Attention: the file 'src/lib/vtk_fortran_xxx.f90' depends on 'penf' that is unreachable

With make:

$make VTKFortran
make: *** No rule to make target 'src/third_party/PENF/src/lib/penf.F90', needed by 'static/obj/penf.o'.  Stop.

[szaghi]

@rob-777

I am very sorry for my delay.

It seems that you have not downloaded all the submodules, please make sure that into the path src/third_party/ there are all the submodules, namely BeFoR64, FACE, FoXy, PENF and StringiFor. Probably you have not recursively cloned the repository with the submodules, e.g. git clone --recurse-submodules [email protected]:szaghi/VTKFortran.git.

Let me know if I can help further.

[szaghi]

@AliE89

I think I can close this issue, are you agree?

[AliE89]

Hello guys, I had the same issue so far, just make sure you have penf and the other bu ch of dependencies in your third party directory. If you are in troubles, I can share my copy of vtk fortran which runs just fine!

…

On Fri, 12 Mar 2021, 09:00 Stefano Zaghi, ***@***.***> wrote: @AliE89 <https://github.com/AliE89> I think I can close this issue, are you agree? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#26 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AL4ZV6SYJUNHEGG4E236AQLTDHCZHANCNFSM4JLJTRDA> .