fix(nui/PlayerModel): require OneSync for bring and goto #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GetPlayerPed is only available on the server-side, if OneSync is enable - note that it works on both legacy and infinity. having onesync off, which result in an invalid entity, resulting in the target coords being 0,0,0
tabarra
requested changes
Sep 18, 2023
| @@ -77,7 +77,8 @@ | |||
| "not_enabled": "The txAdmin Menu is not enabled! You can enable it in the txAdmin settings page.", | |||
| "announcement_title": "Server Announcement by %{author}:", | |||
| "directmessage_title": "DM from admin %{author}:", | |||
| "dialog_empty_input": "You cannot have an empty input." | |||
| "dialog_empty_input": "You cannot have an empty input.", | |||
| "onesync_error": "This option requires OneSync to be enabled." | |||
There was a problem hiding this comment.
Note to future self: perhaps remove nui_menu.page_main.vehicle.onesync_error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetPlayerPed is only available on the server-side, if OneSync is enable - note that it works on both legacy and infinity. having onesync off, which result in an invalid entity, resulting in the target coords being 0,0,0.
note: untested, but should work just fine