Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patched version - WebView2 #740

Open
Leo9idas opened this issue Mar 31, 2024 · 12 comments
Open

Patched version - WebView2 #740

Leo9idas opened this issue Mar 31, 2024 · 12 comments

Comments

@Leo9idas
Copy link

OS info : TE64 24.2.27 Microsoft Windows 11 Pro 64-bit 23H2 (10.0.22631) Dark WebView2/123.0.2420.65 JS/Chakra.dll en_us 96

There is a problem with webview2 and the patched version.
Steps to reproduce the behavior :

  • Open "TE64" and click on a toolbar/linkbar cascaded menu.
    ERROR "Unable to get property "x" of undefined or null reference (0x800a138f) Line: 7889
    -Open Options, close and click again. No error but the drop-down position of the cascaded toolbar menu appears off position.
    If you try to edit the toolbar option/button/menu there is no update inside the settings.
    In general and additionally with webview2 installed and the patched version when you make a css change a restart is needed to update the change (e.g a button move).
@ccfs
Copy link

ccfs commented Mar 31, 2024

What do you get if you repeat the same steps on OFFICIAL VERSION (TE and add-ons) ?

@Leo9idas
Copy link
Author

What do you get if you repeat the same steps on OFFICIAL VERSION (TE and add-ons) ?

In the official version everything works as intended

@ccfs
Copy link

ccfs commented Mar 31, 2024

What if you repeat the same steps on patched version but with WebView2 disabled?

@Leo9idas
Copy link
Author

I already did :) With webview2 disabled everything works. Probably webview2 is not included in this patch for 24.2.27 patched version.

@ccfs
Copy link

ccfs commented Mar 31, 2024

Which "cascaded menu" do you refer to? The menu (of folders and files) shown after clicking the v drop-down button, or the menu (of tool bar items) you made by enclosing items with a Menus/Open and Menus/Close pair?

Can you show me some screen captures of the menu and the error message box?

Besides, from which bar (position) is the menu - default position (with circule filled on Position tab) or others (not filled, i.e. a second tool bar)?

@Leo9idas
Copy link
Author

Leo9idas commented Mar 31, 2024

-webview toolbar settings -webview toolbar settings
no-webview_cascaded menu no-webview_cascaded menu
no-webview_popup no-webview_popup
-webview_popuponclick -webview_popuponclick
-webview_popup-position-after-forced-update -webview_popup-position-after-forced-update

@ccfs
Copy link

ccfs commented Apr 1, 2024

Please replace linkbar/toolbar and options.js in script folder with this.

I have changed those parts which might cause the problems. Since I am on Windows 7, I cannot install Edge and WebView2. I cannot test whether the updates will work. Please let me know the result at your side. Thanks.

@Leo9idas
Copy link
Author

Leo9idas commented Apr 1, 2024

I tested with the new trial but the same thing happens. The strange thing is that now happens with the normal version !!! I think it is not a problem with linkbar/toolbar specifically. It is a problem with webview2 and the recent updates microsoft released.
I tested it also in a windows sandbox and it seemed to work ok but after a webview2 version installed the problems began !
Tested also in a windows 10 installation of mine... the same. Thank you for your efforts but I think I will stop using webview for now. It would be good if someone else shared their experience. Is it only me that has this problem ? Thank you !

@ccfs
Copy link

ccfs commented Apr 2, 2024

I think that there are 2 problems:
(1) On Options page, record details are not refreshed to the selected item on the list.
(2) "View" menu problem - "Unable to get property 'x' of undefined or null reference" or off position.

[A] Do both problems happen on the normal version?

[B] I find that the version of TE WebView2 on download page https://tablacus.github.io/tewv2.html is 24.1.9, but on release page https://github.com/tablacus/TablacusExplorerWebView2/releases is 24.3.9. Can the newer release solve any one of the problems on the normal version?

[C] Do the trial solve any one of the problems?

[D] With WebView2 disabled, do the trial cause any new problem on Windows 10/11?

Thanks.

@Leo9idas
Copy link
Author

Leo9idas commented Apr 2, 2024

A. (1) record details are refreshing (2) is happening. (if I click in folder view on a file to register position there is no error but dropdown stays at the file.
(B) I update webview inside the add-on so it downloads version 24.3.9. (Microsoft update I think is newer than the addon compile)
(C) + (D) Trial is working excellent for me in the patched version (24.2.27) with no webview2 of course.
Thank you again for looking into the matter.

@ccfs
Copy link

ccfs commented May 10, 2024

The problems have been solved with the latest patch (2024/5/9).

@Leo9idas
Copy link
Author

The problems have been solved with the latest patch (2024/5/9).

I thought this was unsolvable but "in Tablacus we Trust" !!!! Thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants