-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚀 - Drawer
should not define content styles
#9680
Comments
We want it to follow our design specs out of the box but be easily customizable. Maybe we can move padding to host element and then compensate it with negative margins on header and footer? I assume if you want custom padding, you are not using header + footer? Alternatively to negative margins we can use box-shadow to cover content when header is sticky and some of the content might stick out to the padding area. |
No, I am not using header and footer. |
Would you like to make a PR to speed it up? |
I can do it. |
Ok, but that's not going to be soon because I'll be away for a few weeks |
That's ok, it's not a major issue. |
Description
When migrating from the old
Sidebar
to the newDrawer
component I've noticed that the new component forces content styles on you.Now in order to customize content CSS you have to use
::ng-deep
on the.t-content
element.This is an issue not only if you want custom paddings, but also if you want custom background or custom content height (ie
100%
).I would suggest making
.t-content
intodisplay: contents
kind of element and let users supply their own content styles instead.The text was updated successfully, but these errors were encountered: