Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 - Ability to set tuiHintManual as null #9935

Open
MuhammedSmani opened this issue Dec 6, 2024 · 2 comments · May be fixed by #9955
Open

🚀 - Ability to set tuiHintManual as null #9935

MuhammedSmani opened this issue Dec 6, 2024 · 2 comments · May be fixed by #9955
Labels
community contribution This issue was closed by a PR from the community P3 This issue has low priority

Comments

@MuhammedSmani
Copy link

Description

Ability to set tuiHintManual as null will provide users with a dynamic usage of the tuiHintManual in tuiHint.

So, whenever someone has a case where they want to sometimes use tuiHintManual and sometimes use the tuiHint auto show/hide they can achieve that buy sending [tuiHintManual]='alwaysShow ? true : null'.

Right now it only accepts boolean values.

Thank you.

@waterplea waterplea changed the title 🗂 - Ability to set tuiHintManual as null 🚀 - Ability to set tuiHintManual as null Dec 6, 2024
@waterplea waterplea added P3 This issue has low priority contributions welcome Architecture is clear and community can help labels Dec 6, 2024
@waterplea
Copy link
Collaborator

Sounds reasonable and should be easy to implement by enabling hover hint in ngOnChanges if the value is null:
https://github.com/taiga-family/taiga-ui/blob/main/projects/core/directives/hint/hint-manual.directive.ts#L24
Would you like to make a PR?

@MuhammedSmani
Copy link
Author

Sounds reasonable and should be easy to implement by enabling hover hint in ngOnChanges if the value is null: https://github.com/taiga-family/taiga-ui/blob/main/projects/core/directives/hint/hint-manual.directive.ts#L24 Would you like to make a PR?

Thank you for your reply, I will open a PR soon.

@waterplea waterplea added community contribution This issue was closed by a PR from the community and removed contributions welcome Architecture is clear and community can help labels Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community contribution This issue was closed by a PR from the community P3 This issue has low priority
Development

Successfully merging a pull request may close this issue.

2 participants