Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 - TuiSkeleton animation speed slow down after speed up TUI_ANIMATIONS_SPEED #9778

Open
simonenkof opened this issue Nov 18, 2024 · 2 comments · May be fixed by #9984
Open

🐞 - TuiSkeleton animation speed slow down after speed up TUI_ANIMATIONS_SPEED #9778

simonenkof opened this issue Nov 18, 2024 · 2 comments · May be fixed by #9984
Assignees
@Jonesso
Labels
community contribution This issue was closed by a PR from the community P3 This issue has low priority S3 This issue has low severity

Comments

@simonenkof
Copy link
Contributor

Reproduction url

https://stackblitz.com/edit/angular-qoqwp3?file=src%2Fapp%2Fapp.template.html

Description

When you speed up animations TUI_ANIMATIONS_SPEED, the animation speed of TuiSkeleton (maybe something else) slows down a lot.

Taiga UI version

4.15.0

Browser Used

Chrome

OS Used

macOS
@waterplea
Copy link
Collaborator

Looks like we forgot to use tuiGetDuration here:
https://github.com/taiga-family/taiga-ui/blob/main/projects/kit/directives/skeleton/skeleton.directive.ts#L42

@waterplea waterplea added contributions welcome Architecture is clear and community can help P3 This issue has low priority S3 This issue has low severity labels Nov 26, 2024
@Jonesso
Copy link

Jonesso commented Dec 6, 2024

I'll take it

@Jonesso Jonesso linked a pull request Dec 13, 2024 that will close this issue
Open
@waterplea waterplea added community contribution This issue was closed by a PR from the community and removed contributions welcome Architecture is clear and community can help labels Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jonesso Jonesso

Labels
community contribution This issue was closed by a PR from the community P3 This issue has low priority S3 This issue has low severity
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(kit): skeleton animation speed slow down after speed up TUI_ANIMA… Jonesso/taiga-ui
3 participants
@waterplea @Jonesso @simonenkof