Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): DropdownOpen focus item in dropdown upon opening #8112

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

waterplea
Copy link
Collaborator

Closes #

Copy link

lumberjack-bot bot commented Jul 16, 2024

Failed tests ❌

After <= Diff => Before

tests-core-data-list-data-list-DataList-Complex-chromium/08-data-list.diff.png
tests-core-data-list-data-list-DataList-Submenu-chromium/03-1-data-list.diff.png
tests-core-dropdown-dropdown-Dropdown-Esc---Hosted-Dropdown-chromium/06-dropdown.diff.png

(updated for commit 2f209fc)

Copy link
Contributor

github-actions bot commented Jul 16, 2024

Visit the preview URL for this PR (updated for commit 2f209fc):

https://taiga-ui--pr8112-select-nk5puttl.web.app

(expires Thu, 18 Jul 2024 08:49:05 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

Copy link

bundlemon bot commented Jul 16, 2024

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/styles.(hash).css
11.41KB (+133B +1.15%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/main.(hash).js
285.03KB +10%
demo/browser/vendor.(hash).js
227.11KB +10%
demo/browser/runtime.(hash).js
40.88KB +10%
demo/browser/polyfills.(hash).js
11.21KB +10%

Total files change +136B +0.02%

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
6.63MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@waterplea
Copy link
Collaborator Author

The tabs screenshot showcases this issue:
#837
Now that we got rid of hosted dropdown and polymorpheus allows to pass active zone automatically it should be easier to fix it.

@splincode splincode marked this pull request as draft November 11, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants