-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracking issue for 1.0.0 release #264
Comments
Sounds good 👍 If I remember correctly, there are basically only 3 changes required:
|
Another likely change is to remove support for rust 1.34-1.36 and remove the build-script, but I have no particular strong opinion on this. |
266: Remove Replace argument r=taiki-e a=taiki-e cc #264 Co-authored-by: Taiki Endo <[email protected]>
265: Remove project, project_ref, and project_replace attributes r=taiki-e a=taiki-e cc #264 Co-authored-by: Taiki Endo <[email protected]>
268: Do not expose unnamed projected types r=taiki-e a=taiki-e Defines projected types in inside `const _: () = {}` when the users don't name it; cc #264 Co-authored-by: Taiki Endo <[email protected]>
278: Release 1.0.0-alpha.1 r=taiki-e a=taiki-e [Changes](https://github.com/taiki-e/pin-project/blob/a1da018ce82073aec4d76bfdfa554c297bd77bd3/CHANGELOG.md#100-alpha1---2020-09-22) cc #264 Co-authored-by: Taiki Endo <[email protected]>
278: Release 1.0.0-alpha.1 r=taiki-e a=taiki-e [Changes](https://github.com/taiki-e/pin-project/blob/a1da018ce82073aec4d76bfdfa554c297bd77bd3/CHANGELOG.md#100-alpha1---2020-09-22) cc #264 Co-authored-by: Taiki Endo <[email protected]>
278: Release 1.0.0-alpha.1 r=taiki-e a=taiki-e [Changes](https://github.com/taiki-e/pin-project/blob/a1da018ce82073aec4d76bfdfa554c297bd77bd3/CHANGELOG.md#100-alpha1---2020-09-22) cc #264 Co-authored-by: Taiki Endo <[email protected]>
Released 1.0.0-alpha.1. I'll wait for a few weeks and then release 1.0.0 if we don't have any big issues. |
Previously, I said "we need to decide on a policy when we release 1.0" in #219 (comment). |
FWIW, here is a list of language features/changes that I think may affect pin-project(-lite) in the future:
(There are many uncertainties, so this list does not include anything like significant changes in the existing macro system, unapproved RFCs, or pre-RFCs.) |
292: Bump MSRV to 1.37 r=taiki-e a=taiki-e Bumps MSRV to 1.37 because `underscore_const_names` requires 1.37. This allows removing the build script. It's been more than a year since [1.37 was released](https://blog.rust-lang.org/2019/08/15/Rust-1.37.0.html), and most of the users of this crate depend on `futures_api` that requires 1.36 and `async_await` that requires 1.39. so bumping MSRV to 1.37 is probably no problem. Also, given that pin-project-lite's MSRV is 1.37 and the possibility of switching, most futures-related utilities require at least 1.37. cc #264 Refs: #219 Co-authored-by: Taiki Endo <[email protected]>
Current pre-release: 1.0.0-alpha.1
There haven't been any API changes since the
#[project]
attribute was deprecated. Since there are currently no open issues, I think it's a good time to release version 1.0.0.Since this is a Semver-incompatible release, we could take the opportunity to remove the
#[project]
,#[project_ref]
, and#[project_replace]
attributes. Otherwise, I don't think any changes need to be made other than bumping the version number.The text was updated successfully, but these errors were encountered: