rewrite read_body to carry conn forward #177
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #175
with some caveats:
{:stream, X}
was returned. It was not clear whether this ever worked with any other adapter thanHTTPoision
- Investigate restoring streaming request body through to upstream #176 tracks the work here. But we are now storing in memory request bodies that may have previously been streamed.read_body
interface (the return value) changes, but this shouldn't be considered part of the public interface for the plug