Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite read_body to carry conn forward #177

Merged
merged 1 commit into from
Feb 24, 2024
Merged

Conversation

mwhitworth
Copy link
Collaborator

fixes #175

with some caveats:

  • this removes the behaviour where {:stream, X} was returned. It was not clear whether this ever worked with any other adapter than HTTPoision - Investigate restoring streaming request body through to upstream #176 tracks the work here. But we are now storing in memory request bodies that may have previously been streamed.
  • the read_body interface (the return value) changes, but this shouldn't be considered part of the public interface for the plug

@mwhitworth mwhitworth merged commit e5ac120 into master Feb 24, 2024
1 check passed
@mwhitworth mwhitworth deleted the pass-conn-read-body branch February 24, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken in Bandit (also silently in Cowboy)
1 participant