Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make snippet watcher more fine-grained #1373

Open
pokey opened this issue Jan 23, 2024 · 1 comment
Open

Make snippet watcher more fine-grained #1373

pokey opened this issue Jan 23, 2024 · 1 comment

Comments

@pokey
Copy link
Collaborator

pokey commented Jan 23, 2024

The snippet watcher code is currently triggering a lot of work inside Talon. We'd like to only update the file that changed in the fs.watch

Alternately, we could remove support for custom user snippets dir, but that would mean dropping support for #1306

Originally posted by @lunixbochs in #1348 (comment)

@AndreasArvidsson
Copy link
Collaborator

The problem is that snippets can override each other. We have a priority system where typescript reacts wins over typescript and so on. The scenario where if they have removed a definition and we now should fall back to a previous one requires us to keep the content of all files and then figure out what lists have actually updated. Fully doable, but not as simple as just rereading a single file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants