Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor shield functions: #274

Open
wants to merge 6 commits into
base: gh-pages
Choose a base branch
from
Open

Refactor shield functions: #274

wants to merge 6 commits into from

Commits on Dec 8, 2018

  1. Refactor sprite functions: 

    - Return no sprite when text is too long to discard them instead of
  using an additional js call to filter them
- Don't allocate memory for building strings
- Don't spend cpu cycles on building strings, hashing and storing them.
    @hjanetzek
    hjanetzek committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    f283337 View commit details
    Browse the repository at this point in the history

  2. Add back special 4-5 char priority filter

    @hjanetzek
    hjanetzek committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    ccf6081 View commit details
    Browse the repository at this point in the history

  3. Move visible: global.sdk_road_shields to overall 'shields' layer

    @hjanetzek
    hjanetzek committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    a11dfe7 View commit details
    Browse the repository at this point in the history

  4. global.ux_language_text_source formatting and cleanups 

    - Don't keep comments in JS code - we have to parse the source strings
  and keep them around. When possible use yaml comments.
    @hjanetzek
    hjanetzek committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    1b7e6fb View commit details
    Browse the repository at this point in the history

  5. Fix duplicate US-US:

    @hjanetzek
    hjanetzek committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    cd16294 View commit details
    Browse the repository at this point in the history

  6. Unset 'generic' sprite fallback for shields 

    - can be enabled for debugging to see which shields were
  discarded by the sprite functions
    @hjanetzek
    hjanetzek committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    3d56897 View commit details
    Browse the repository at this point in the history