Fix comment block detection and handling per tap specification #9
Conversation
TAP Version 13 says that comment blocks can be indented with any number of spaces. Changed detection regexes to match specification and added detection to remove the correct number of spaces from each line in the comment block. Removed the --- and ... lines as they're not valid YAML.
Codecov Report
@@ Coverage Diff @@
## master #9 +/- ##
=========================================
Coverage ? 97.88%
=========================================
Files ? 1
Lines ? 189
Branches ? 0
=========================================
Hits ? 185
Misses ? 4
Partials ? 0
Continue to review full report at Codecov.
|
|
Thanks! Good catch. Can I get you to add a test that proves the change? Then it's mergeable! 🎉 |
|
Sure thing!
…On Wed, Feb 15, 2017, 5:01 AM Scott Corgan ***@***.***> wrote:
Thanks! Good catch.
Can I get you to add a test that proves the change? Then it's mergeable!
🎉
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#9 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAU6DPgfbfuIxBimZY0Ecv9ids5S3m7Vks5rcvcPgaJpZM4MBoa1>
.
|
|
Also if you have any idea how to rewrite |
abrenneke
force-pushed
the
fix-yaml-indent-parsing
branch
from
541081f to
0dbc466
Compare
|
Sorry about the delay @scottcorgan, work kept me busy. I've added tests which fail on @tap-format/parser/master and succeed in my branch. I can squash the two commits if you'd like. |
TAP Version 13 says that comment blocks can be indented with any number
of spaces. Changed detection regexes to match specification and added
detection to remove the correct number of spaces from each line in the
comment block. Removed the --- and ... lines as they're not valid YAML.
Fixes #8