Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.0] Use Plates v4 #300

Open
carbontwelve opened this issue Feb 22, 2018 · 1 comment
Open

[2.0] Use Plates v4 #300

carbontwelve opened this issue Feb 22, 2018 · 1 comment
Assignees
@carbontwelve
Labels
enhancement in-progress
Milestone
2.0.0

Comments

@carbontwelve
Copy link
Member

carbontwelve commented Feb 22, 2018 •
edited
Loading

This will likely require extensive modification to how Tapestry interacts with Plates due to the very nature of Tapestry having extended Plates to implement some features.

It looks as though with v4 that those extensions may no longer be required, which is nice.
@carbontwelve carbontwelve added this to the 2.0.0 milestone Feb 22, 2018
@carbontwelve carbontwelve self-assigned this Feb 22, 2018
carbontwelve added a commit that referenced this issue Feb 22, 2018
@carbontwelve
(#300) Use Plates v4, this restricts us from launching 2.0 until v4 i…
a90a576 
…s stable
carbontwelve added a commit that referenced this issue Feb 22, 2018
@carbontwelve
(#300) Refactored most Plates Extensions
41b7803
carbontwelve added a commit that referenced this issue Feb 22, 2018
@carbontwelve
(#300) Refactored to use Plates v4
12eeeaf
carbontwelve added a commit that referenced this issue Feb 23, 2018
@carbontwelve
Various 2.0 Amends (#304)
13e4464 
* 🚚 added two new steps for #297 in new folder as per #282

* 🚚 drafting things out

* 🔥 disabling 1.* tests for refactoring

* 🚚 tinkering

* 🚚 filling in ProjectFile methods from File

* Refactoring to use ProjectFile

* Updating dependencies as per #270, this breaks everything...

* (#270) Update for working with 7.0

* Store uid in meta array so File object can be duplicated correctly

* (#284) Refactoring project to use ProjectFile

* (#300) Use Plates v4, this restricts us from launching 2.0 until v4 is stable

* (#284) Refactored out File entity usage for ProjectFile

* (#270) Refactored test for 7.0 - passing

* (#270) Enabling a handfull of tests - passing

* (#300) Refactored most Plates Extensions

* (#282) Refactored LoadSourceFileTree

* (#300) Refactored to use Plates v4

* Apply fixes from StyleCI (#301)

Unit tests allowed to fail

* (#270) lock file was generated on 7.2, needs removing so 7.0 unit tests "pass"
@carbontwelve
Copy link
Member Author

When I wrote this issue I expected version four of plates to launch within the year; once all other version 2 issues are complete maybe re-evaluate stripping plates v4 commits into a separate branch and launching version 2 with plates v3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carbontwelve carbontwelve

Labels
enhancement in-progress
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@carbontwelve