Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.0] Abstract sources #302

Closed
carbontwelve opened this issue Feb 23, 2018 · 1 comment
Closed

[2.0] Abstract sources #302

carbontwelve opened this issue Feb 23, 2018 · 1 comment
Assignees
@carbontwelve
Labels
enhancement refactoring
Milestone
2.0.0

Comments

@carbontwelve
Copy link
Member

The File entity that is used throughout Tapesty has been slimmed down and refactored to a ProjectFile class as per #284.

To enable alternative sources such as database, web api or programmatic the ProjectFile entity should be abstracted into a project entity interface. That interface can then be implemented by a base AbstractEntity which could then be extended by final classes such as: FilesystemSourceProjectFile, DatabaseSourceProjectFile, etc.

Source collectors could then be registered via configuration to fill the project entity table, with the default collector being FilesystemCollector.

Doing this would allow Tapestry to collect from a variety of sources and while the most useful use case is filesystem, it would make writing a management dashboard easier if it could read directly from a database.
@carbontwelve carbontwelve added this to the 2.0.0 milestone Feb 23, 2018
@carbontwelve carbontwelve self-assigned this Feb 23, 2018
carbontwelve added a commit that referenced this issue Feb 23, 2018
@carbontwelve
(#302) preparation of abstract source for implementing #297
d7dbbe7
carbontwelve added a commit that referenced this issue Feb 24, 2018
@carbontwelve
(#302) Disabling failing test until bootstrapping for #297 is complete
0beeed3
carbontwelve added a commit that referenced this issue Feb 24, 2018
@carbontwelve
(#302) Moved getRenderedContent method to AbstractSource
af28822
carbontwelve added a commit that referenced this issue Feb 24, 2018
@carbontwelve
(#302) Boilerplating collectors. These are a refactoring of the LoadS…
a25830a 
…ourceFileTree step into abstracts
@carbontwelve carbontwelve mentioned this issue Feb 24, 2018
Open
carbontwelve added a commit that referenced this issue Feb 28, 2018
@carbontwelve
(#302) added filtering to filesystem collector
e82e13c
carbontwelve added a commit that referenced this issue Feb 28, 2018
@carbontwelve
(#302) added collector collection...
0de5a64
carbontwelve added a commit that referenced this issue Feb 28, 2018
@carbontwelve
(#302) boilerplating collector's loader step
3a3fc6f
@carbontwelve
Copy link
Member Author

Abstract sources have been implemented as part of issue #297

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carbontwelve carbontwelve

Labels
enhancement refactoring
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@carbontwelve