Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnitTest ContentType to ensure it works as expected #322

Open
carbontwelve opened this issue Oct 8, 2018 · 2 comments
Open

UnitTest ContentType to ensure it works as expected #322

carbontwelve opened this issue Oct 8, 2018 · 2 comments
Assignees
@carbontwelve
Labels
bug enhancement in-progress
Milestone
2.0.0

Comments

@carbontwelve
Copy link
Member

carbontwelve commented Oct 8, 2018 •
edited
Loading

While working on The TaxonomyArchiveGenerator for #315 I stumbled upon a half complete refactoring of ContentType.

It would appear that back in March 2018 I ContentType was refactored with the idea being that it would store references to SourceInterface within its $items property instead of the uid -> timestamp format that had been used in version one of Tapestry.

This was done so that the Project container wouldn't need to be handed around so much with the content type being able to hand back the relevant SourceInterfaces for getSourceList.

Before closing this will need duplicating for Taxonomy.
@carbontwelve carbontwelve added this to the 2.0.0 milestone Oct 8, 2018
@carbontwelve carbontwelve self-assigned this Oct 8, 2018
carbontwelve added a commit that referenced this issue Oct 8, 2018
@carbontwelve
Discovered work needing done for #322 before continuing on #315
7159887
carbontwelve added a commit that referenced this issue Oct 8, 2018
@carbontwelve
Unit Tests for #322
e262ea8
carbontwelve added a commit that referenced this issue Oct 9, 2018
@carbontwelve
Adding tests for #322
1c73127
@carbontwelve
Copy link
Member Author

carbontwelve commented Oct 11, 2018 •
edited
Loading

Majority of this issue is completed by #323.

@carbontwelve carbontwelve reopened this Oct 11, 2018
@carbontwelve
Copy link
Member Author

I closed this prematurely, Taxonomy needs modifying so it contains reference to the Source's as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carbontwelve carbontwelve

Labels
bug enhancement in-progress
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@carbontwelve