Skip to content
This repository has been archived by the owner on Aug 27, 2024. It is now read-only.

make addrpx behavior similar to new account behavior #16

Open
jjb opened this issue Mar 8, 2010 · 2 comments
Open

make addrpx behavior similar to new account behavior #16

jjb opened this issue Mar 8, 2010 · 2 comments
Labels

Comments

@jjb
Copy link
Contributor

jjb commented Mar 8, 2010

when creating a new account, presence of email validations are ignored. when adding an rpx provider to an existing account, they are not ignored.

last night i was trying to fix this and found the relevant place in the code to fix this, but now i can't find it.

if you don't even know what i'm talking about, let me know. if i figure out what my idea was, i'll share it here.

cheers,
john

@jjb
Copy link
Contributor Author

jjb commented Mar 8, 2010

maybe this will help understanding the problem:

acts_as_authentic do |c|
  c.account_mapping_mode :internal
  merge_validates_length_of_email_field_options :if => Proc.new { |user| !user.email.nil? }
  merge_validates_format_of_email_field_options :if => Proc.new { |user| !user.email.nil? }
end

The merge_foo lines are not needed for creating a new account, but they are needed for adding an rpx provider to an existing account.

@tardate
Copy link
Owner

tardate commented Mar 13, 2010

Hi John, good catch on this issue, and thanks for the patch - I'll check it out / integrate it asap.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants