Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom notation offset? #39

Open
adamjakab opened this issue Jul 19, 2014 · 4 comments
Open

custom notation offset? #39

adamjakab opened this issue Jul 19, 2014 · 4 comments

Comments

@adamjakab
Copy link

Why is my custom notation %X/X.0/0.0/0.2/1.3/2.2/3[Re] is not rendering as the built in "D" chord? It is correct but mine is getting moved up by a fret. jtab
Is there something I am doing wrong?

@tardate
Copy link
Owner

tardate commented Jul 20, 2014

Hi Adam, it seems like a limitation of the custom notation handling.

These are both correct / same chord, but the custom notation has decided to draw the chord diagram from fret 1, not the nut in the standard diagram.

I don't think there's a way to force it to draw otherwise in the current jTab.

Actually it should make a better guess in this case - it is 'obvious' it should draw the diagram from root position

@tardate
Copy link
Owner

tardate commented Jul 20, 2014

btw, was your intention to simply translate the names of standard chords? Yes, translation for a range of languages/traditions would be a nice feature to have

@adamjakab
Copy link
Author

No, not really - I am playing about with JTab because I want to put up an on-line service (mostly for my own necessities) where one can register songs with chords (view/print them with chord diagrams) and compile songs into song-books. Something very simple. When I found jTab I got really happy because it has everything I need for this project but because I want to set up my own database of chords (so that the user can choose from a variety of C chords to use in that specific song) I do not want to rely on jTab's build-in definitions. This brought me to check on the custom notation (which again is excellent).
I find your notation hard to read: %Fret/Finger.Fret/Finger.Fret/Finger.Fret/Finger.Fret/Finger.Fret/Finger[Name] so I came up with my own (which is probably easier to read only for me): offset#finger@fret/finger@fret/finger@fret/finger@fret/finger@fret/finger@fret.
The main difference being that I extract the initial fret offset from all fret values. So instead of writing
finger 1 @ fret 12 / finger 2 @ fret 13 ... I write offset 12 # finger 1 @ fret 1 / finger 2 @ fret 2 ...

As I said I was just playing about up until I came to D chord and I posted you the question. Actually, with your custom notation there is no way to instruct the renderer to render %X/X.0/0.0/0.2/1.3/2.2/3[Re] as the built in D chord - that is - from the nut(is this how you call it?). With a notation where you can explicitly set the starting position (like mine [clap-clap] ;)) you would be able to do that with 0#x/0/0/1@2/3@3/2@2. Obviously, jTab library should be modified for this.

So, my plans are: 1) for now I have created a 'translator' which translates my notation to jTab notation and I will live with moved D chord(which is still correct anyways). 2) make this project of mine work and put it up somewhere (i'll give u notice when there is something usable). 3) maybe one day check if I want to fix this thing, remove the translator business and add/extend jTab so that it can also understand this type of notation.

Anyways, thanks for jTab. I have not found anything like it on the net.

@szydan
Copy link

szydan commented Apr 8, 2018

If anyone is still interested in forcing to draw a tab from a specific position I've made a change in my fork of jtab
Here is a simple page to try
https://szydan.github.io/jtab/
I've made it as I needed it for my own personal use of "Custom Chord Notation"
I've extended the notation with {FRET_NUMBER} at the end
explained here
https://szydan.github.io/jtab/changes/changes.html
I can make a PR to contribute this change back

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants