Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate line opacities looping through lines rather than frequencies #184

Open
jvshields opened this issue Mar 15, 2024 · 0 comments
Open

Comments

@jvshields
Copy link
Contributor

#92 is an attempt at this, but I'm not sure it's been fully tested and also would need to be updated to work with the parallel implementation.

However, the current way we calculate line opacities is by looping through frequencies and seeing if there are lines close that contribute to opacity in that bin.

We could do far fewer calculations by looping through lines and calculating the frequency bins they contribute opacity to. It would also be straightforward at that point to do an additional calculation when considering the line to decide how broad to consider it. This variable broadening range scaling is used by other codes and the cost of doing an additional per line calculation should still be fast compared to the way we do things now where we probably consider many more unnecessary lines at each frequency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant