Windows 11: Rewards: Rewards History displayed incorrectly. There is history that I have not won displayed #1317
Assignees
Labels
Comments
Tas4tari
changed the title
Tas4tari
changed the title
brianp
added a commit
that referenced
this issue
Jan 21, 2025
Fixes: * #1346 * #1317 * partially #883 Description -- Since tari-project/tari#6733 is merged, we can now implement pagination for infinite scrolling. Wallets with extensive transaction history can now open `latest wins` tab without performance issues. Changes -- * Infinite scrolling in the "latest wins" tab * Filter only `COINBASE_UNCONFIRMED` and `COINBASE_CONFIRMED` transactions(blocks wins). Rename methods from `get_transaction_history` to `get_coinbase_transactions` to reflect changes. * `get_coinbase_transactions` handles pagination - we define `continuation` and `limit`(can be ommitted to fetch all at once) * We fetch already ordered transactions, we don't need to sort it again * Refresh the data everytime when either we open "recent wins" tab or new block is mined * Split `Wallet` component into `WalletMarkup` and `History` to improve performance(reduce rerenders) Testing -- Just play with the "recent wins" tab --------- Co-authored-by: Brian Pearce <[email protected]>
|
Should be fixed with #1343 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
and others
Describe the bug
As a user that has just imported a wallet that has a balance, I find that when I view Rewards, there is a list of rewards history that should not be there as I had only ever won 1 block and had the rest of the balance sent to me by someone.
The only block that I did mine successfully was on October 31- Block: #35744
To Reproduce
Steps to reproduce the behavior:
Seed wordsSeed wordsRewardslink within the Wallet balance sectionRewardshistoryExpected behavior
User should only see the history of the blocks that they have won
Screenshots
Device:
Additional context
logs.zip
The text was updated successfully, but these errors were encountered: