Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure when simultaneous call when adding repository #118

Open
panglesd opened this issue Sep 29, 2022 · 0 comments
Open

Failure when simultaneous call when adding repository #118

panglesd opened this issue Sep 29, 2022 · 0 comments

Comments

@panglesd
Copy link
Contributor

Opam.Repository.add and thus also Installed_repo.with_repo_enabled will fail if the repo that we are trying to add is already there. This makes one of the execution of the platform fail if one tries to add the cache while it was already been added by the other instance.

We should be careful, as we also do not want to continue as if nothing was done. Indeed, the instance that added the repo might remove it before we have finished.
We should maybe pick a random name for the repository and return it, so that we have our own repository per running instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant