Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conform to Zsh Plugin Standard (mostly) #35

Merged
merged 1 commit into from
Dec 16, 2020
Merged

Conform to Zsh Plugin Standard (mostly) #35

merged 1 commit into from
Dec 16, 2020

Conversation

jandamm
Copy link
Owner

@jandamm jandamm commented Dec 11, 2020

  1. Standardized $0 Handling - Yes
  2. Functions Directory - Yes
  3. Binaries Directory - Sort of*
  4. Unload Function - Doesn't apply
  5. @zsh-plugin-run-on-unload Call - Doesn't apply
  6. @zsh-plugin-run-on-update Call - No
  7. Plugin Manager Activity Indicator - Yes
  8. Global Parameter ZPFX - Yes
  9. Global Parameter holding capabilities - Yes

* I don't think it is a good idea to automatically add every bin
folder to the PATH. If the user wants this zgenom bin <repo> does so.

Closes #27
Closes tarjoilija/zgen#104
Closes tarjoilija/zgen#124

@jandamm
Conform to Zsh Plugin Standard (mostly)
387a8db 
1. Standardized $0 Handling              - Yes
2. Functions Directory                   - Yes
3. Binaries Directory                    - Sort of*
4. Unload Function                       - Doesn't apply
5. @zsh-plugin-run-on-unload Call        - Doesn't apply
6. @zsh-plugin-run-on-update Call        - No
7. Plugin Manager Activity Indicator     - Yes
8. Global Parameter ZPFX                 - Yes
9. Global Parameter holding capabilities - Yes

\* I don't think it is a good idea to automatically add every `bin`
folder to the PATH. If the user wants this `zgenom bin <repo>` does so.

Closes #27
Closes tarjoilija/zgen#104
Closes tarjoilija/zgen#124
@jandamm jandamm merged commit 862f5f2 into main Dec 16, 2020
@jandamm jandamm deleted the Conform-to-Zsh-Plugin-Standard-mostly branch December 16, 2020 16:05
This was referenced Dec 17, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Zsh plugin standard? Support Zsh Plugin Standard
1 participant
@jandamm