-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support single_dep
and multi_dep
functionality
#227
Comments
Maybe you omitted it because it's fairly trivial to deal with in transforms already, and we may not need or want a generic method, but just for the sake of completeness I'll note that the other major thing that |
Ah yes, good call out! |
These transforms will implement part of the work that the multi_dep loader is doing in other projects. Issue: taskcluster#227
These transforms will implement part of the work that the multi_dep loader is doing in other projects. Issue: taskcluster#227
These transforms will implement part of the work that the multi_dep loader is doing in other projects. Issue: taskcluster#227
These transforms will implement part of the work that the multi_dep loader is doing in other projects. Issue: taskcluster#227
These transforms will implement part of the work that the multi_dep loader is doing in other projects. Issue: taskcluster#227
These transforms will implement part of the work that the multi_dep loader is doing in other projects. Issue: taskcluster#227
These transforms will implement part of the work that the multi_dep loader is doing in other projects. Issue: taskcluster#227
These transforms will implement part of the work that the multi_dep loader is doing in other projects. Issue: #227
The
multi_dep
andsingle_dep
loaders (and related transforms) are some of the most widely copied Taskgraph logic from project to project. We've mentioned upstreaming this into Taskgraph countless times! However, over the years I've come to realize that this loader is unnecessary and overly complicated (most recently while working on mozilla-releng/mozilla-taskgraph#7 in conjunction with the linkedfirefox-android
PR).Essentially it's doing too much at once, building upstream artifacts, copying attributes, resolving keys. The root issue is that it adds a lot of complexity right up front, which every later transform then needs to deal with. Instead we should add complexity little by little, and only as needed.
I'm still formulating thoughts here, but I think my rough plan is to:
upstream-artifacts
from a task's dependencies.primary-dep
.scriptworker
payload builders.I believe with the above pieces, we'll be able to completely obsolete the
single_dep
andmulti_dep
loaders and replace it with a much simpler and easy to follow setup.The text was updated successfully, but these errors were encountered: