Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[en] silence invalid uppercase tag check JSON debug messages #888

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

xxyzz
Copy link
Collaborator

@xxyzz xxyzz commented Oct 28, 2024

too many this kind of messages bury the real check JSON messages

valid_tags and uppercase_tags global variables should use uppercase, but en code import them in many places and website code could also be affected so I didn't rename them.

too many this kind of messages bury the real check JSON messages
@xxyzz xxyzz merged commit f61ff83 into tatuylonen:master Oct 28, 2024
5 checks passed
@xxyzz xxyzz deleted the en branch October 28, 2024 01:11
@kristian-clausal
Copy link
Collaborator

This actually doesn't fix the issue. uppercase_tags doesn't have "Egyptian-Arabic", because that tag is generated and thrown into the tags even though it's not in uppercase_tags. This actually needs two different error messages, the other can have all normal "invalid tags" messages, the other can have "invalid tag but it's uppercase" tags; that should clean it up a bit.

@xxyzz
Copy link
Collaborator Author

xxyzz commented Oct 28, 2024

Err, what? I didn't know that. At least the data in the list won't create debug messages, maybe this will remove most of them. But if there are still many combined uppercase tags, other JSON errors like "empty string" will still be difficult to find.

@kristian-clausal
Copy link
Collaborator

I've made a PR to separate the error messages, check it out to see if I did any embarrassing mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants